Skip to content

fix(miner): expose the freeform idea feasibility gate via a CLI command#6224

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
nghetienhiep:fix/issue-6155
Jul 15, 2026
Merged

fix(miner): expose the freeform idea feasibility gate via a CLI command#6224
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
nghetienhiep:fix/issue-6155

Conversation

@nghetienhiep

@nghetienhiep nghetienhiep commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally — the new lib/idea-feasibility-cli.js is at 100% lines, statements, functions, and branches (23/23); the two changed lib/cli.js help lines add no branches and are covered by the existing printHelp test.
  • npm run test:workers
  • npm run build:mcp / npm run build:miner
  • npm run test:miner-pack (new lib/idea-feasibility-cli.{js,d.ts} packaged)
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate (0 vulnerabilities)
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • UI and worker checks (ui:*, test:workers) are not applicable — this change touches only the miner CLI (packages/loopover-miner/**); no UI, worker, OpenAPI, or MCP surface changed. CI gates those steps conditionally on the affected paths.
  • docs:drift-check and manifest:drift-check were also run and pass.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. (N/A — none touched.)
  • API/OpenAPI/MCP behavior is updated and tested where needed. (N/A — none touched.)
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks. (N/A — no UI.)
  • Visible UI changes include a UI Evidence section. (N/A — no visible UI/frontend/docs/extension change.)
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

Notes

  • feasibility-cli.js is dispatched purely as a local, offline CLI subcommand in bin/loopover-miner.js (before the npm update-check); the new idea-feasibility command is wired identically. Coverage for the new module is measured by Codecov (packages/loopover-miner/lib/**).

Closes #6155

@nghetienhiep
fix(miner): expose the freeform idea feasibility gate via a CLI command
e05795e 
idea-feasibility.js (JSONbored#5789) implemented the pre-compute feasibility gate
for freeform Rent-a-Loop ideas (JSONbored#5671) but had zero callers anywhere in
bin/, lib/, or test/unit -- built against the JSONbored#4779 intake schema and
never wired in.

Wire it through a new `loopover-miner idea-feasibility` subcommand, the
freeform-idea counterpart to the metadata `feasibility` command
(feasibility-cli.js, JSONbored#4270). It follows that command's parse -> execute
-> render precedent so an idea runs through the same buildFeasibilityVerdict
machinery before compute is allocated, except the idea's issueStatus is
derived from its own structure: no objective success signal (--hint) is
invalid/rejected and an unresolvable target (--not-resolvable) is
missing/flagged.

Closes JSONbored#6155
@nghetienhiep nghetienhiep requested a review from JSONbored as a code owner July 15, 2026 23:10
@superagent-security

superagent-security Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.32%. Comparing base (645c3f6) to head (e05795e).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6224      +/-   ##
==========================================
- Coverage   95.32%   95.32%   -0.01%     
==========================================
  Files         597      598       +1     
  Lines       47128    47114      -14     
  Branches    15012    14987      -25     
==========================================
- Hits        44926    44912      -14     
  Misses       1477     1477              
  Partials      725      725
Flag Coverage Δ
shard-1 43.97% <0.00%> (-0.04%) ⬇️
shard-2 36.77% <0.00%> (+0.12%) ⬆️
shard-3 32.22% <0.00%> (+0.01%) ⬆️
shard-4 33.95% <0.00%> (-0.44%) ⬇️
shard-5 31.71% <100.00%> (+0.12%) ⬆️
shard-6 45.21% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/loopover-miner/lib/cli.js 100.00% <ø> (ø)
...ackages/loopover-miner/lib/idea-feasibility-cli.js 100.00% <100.00%> (ø)

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 15, 2026
@loopover-orb

loopover-orb Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-15 23:17:00 UTC

5 files · 1 AI reviewer · no blockers · readiness 82/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This wires the previously-orphaned `assessIdeaFeasibility` gate into a new `idea-feasibility` CLI subcommand, following the existing `feasibility-cli.js` parse -> execute -> render pattern closely, with dispatch added to `bin/loopover-miner.js` and a help-text entry in `cli.js`. The parsing logic (positional validation, `--hint` repeatable flag, `--not-resolvable`, `--json`) is straightforward and the accompanying test file exercises both the parser and the CLI entrypoint end-to-end through the compiled engine dependency. The `deriveIdeaIssueStatus` logic itself lives in `idea-feasibility.js` (not shown in this diff) and is only invoked here, so its correctness can't be verified from this diff alone, but the wiring shown is consistent and testable.

Nits — 3 non-blocking
  • idea-feasibility-cli.js has no filesystem/network access per its own doc comment, but relies entirely on assessIdeaFeasibility's derivation logic which isn't visible in this diff — worth double-checking that deriveIdeaIssueStatus (in idea-feasibility.js) correctly handles all claimStatus/duplicateClusterRisk/hint combinations, since this diff can't confirm that.
  • The help text addition in cli.js splits the idea-feasibility entry across two lines unlike other single-line entries in printHelp, which is a minor formatting inconsistency worth a glance.
  • Consider adding a short worked example to the CLI usage string or docs showing a typical --hint invocation, mirroring feasibility-cli.js's existing help conventions if any exist there.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #6155
Related work ⚠️ 2 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 99 registered-repo PR(s), 53 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor nghetienhiep; Gittensor profile; 99 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Improvement ✅ Minor risk: clean · value: minor · LLM: moderate
Linked issue satisfaction

Addressed
The PR wires assessIdeaFeasibility/deriveIdeaIssueStatus into a real call site (a new idea-feasibility CLI subcommand dispatched from bin/loopover-miner.js), mirroring the feasibility-cli.js precedent, with dedicated unit tests covering parsing, dispositions, and the CLI entrypoint at high coverage.

Review context
Contributor next steps
  • Start here: Review top overlaps.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

loopover-orb[bot]
loopover-orb Bot approved these changes Jul 15, 2026
View reviewed changes

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb loopover-orb Bot merged commit 2af2da3 into JSONbored:main Jul 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loopover-orb loopover-orb[bot] loopover-orb[bot] approved these changes
@JSONbored JSONbored Awaiting requested review from JSONbored JSONbored is a code owner

Assignees

@nghetienhiep nghetienhiep

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix(miner): idea-feasibility.js implements #5671's freeform feasibility gate but nothing calls it

1 participant

@nghetienhiep